LGTM
http://codereview.chromium.org/3538005/diff/1/2 File src/compiler.cc (right): http://codereview.chromium.org/3538005/diff/1/2#newcode409 src/compiler.cc:409: Handle<String>(String::cast(shared->name())), Not your code, but how do we know that shared->name() isn't undefined? Could there be another function to call than shared->name() for the case where the result might be a non-string, so that ->name() always returns a String? http://codereview.chromium.org/3538005/diff/1/4 File src/parser.h (left): http://codereview.chromium.org/3538005/diff/1/4#oldcode196 src/parser.h:196: // source of the script where the function is declared. The start_position and Thank you for removing this sentence. :) http://codereview.chromium.org/3538005/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
