Thanks a lot for review, Lasse. Submitting
http://codereview.chromium.org/3574002/diff/1/5 File src/x64/full-codegen-x64.cc (right): http://codereview.chromium.org/3574002/diff/1/5#newcode1968 src/x64/full-codegen-x64.cc:1968: Condition non_negative_smi = __ CheckNonNegativeSmi(rax); On 2010/09/30 09:30:13, Lasse Reichstein wrote:
Should be masm()-> (or however the macroassembler is accessed here).
The __
macro should not be used for calls that return values.
Oops, thanks a lot. I fixed couple more similar places. http://codereview.chromium.org/3574002/diff/1/8 File src/x64/macro-assembler-x64.h (right): http://codereview.chromium.org/3574002/diff/1/8#newcode316 src/x64/macro-assembler-x64.h:316: void JumpIfNotSmiOrNegative(Register src, LabelType* on_not_smi); On 2010/09/30 09:30:13, Lasse Reichstein wrote:
or negative what? Is it the double (triple?) negation that made you not call it JumpIfNotNonNegativeSmi ? That would be more consistent, but admittedly a bit awkward.
As discussed on IM, we settled down on JumpUnlessNonNegatoveSmi and JumpUnlessBothNonNegativeSmi http://codereview.chromium.org/3574002/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
