Reviewers: Søren Gjesse, Description: Fix HeapSnapshotsDiff test, diff implementation, and a bug introduced during snapshot size optimization.
Sorry, now I figured out that the diff implementation itself was also incorrect. Reachable nodes must be filtered from the beginning, otherwise, an object that is already disconnected, but not discarded yet, will not appear as a deleted (thankfully, this bug for some reason had appeared on the x64 port.) BUG=868 TEST=HeapSnapshotRootPreservedAfterSorting Please review this at http://codereview.chromium.org/3531005/show Affected files: M src/profile-generator.h M src/profile-generator.cc M test/cctest/cctest.status M test/cctest/test-heap-profiler.cc -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
