Should we fix those places as well? Otherwise it looks ugly when API client
need
to do an explicit cast to the enum type instead of just passing result of
or'ed
literals. The cast will break compiler type checks anyway so I think int
parameter with a commentary is more convenient in this case.
On 2010/10/05 13:48:11, Vitaly wrote:
Drive-by comment. This is inconsistent with other similar places in the
API
where we still take an enum-typed argument even if the enum literals can
be
or'ed.
-- Vitaly
http://codereview.chromium.org/3611008/show
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
