LGTM. This looks great!
http://codereview.chromium.org/3584015/diff/2001/3001 File src/conversions.cc (right): http://codereview.chromium.org/3584015/diff/2001/3001#newcode357 src/conversions.cc:357: return sign ? -Strtod(buffer_vector, NULL) : Strtod(buffer_vector, NULL); Isn't the exponent an integer argument? Why use NULL instead of 0? http://codereview.chromium.org/3584015/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
