Yes, LGTM. On Fri, Oct 8, 2010 at 3:10 PM, <[email protected]> wrote:
> Reviewers: Kevin Millikin, > > Description: > Backport r5607 to branches/2.3. > > Please review this at http://codereview.chromium.org/3539019/show > > SVN Base: http://v8.googlecode.com/svn/branches/2.3/ > > Affected files: > M src/full-codegen.cc > M src/version.cc > > > Index: src/full-codegen.cc > =================================================================== > --- src/full-codegen.cc (revision 5606) > +++ src/full-codegen.cc (working copy) > @@ -1014,10 +1014,11 @@ > __ bind(&true_case); > SetExpressionPosition(expr->then_expression(), > expr->then_expression_position()); > - Visit(expr->then_expression()); > - // If control flow falls through Visit, jump to done. > if (context_ == Expression::kEffect || context_ == Expression::kValue) { > + Visit(expr->then_expression()); > __ jmp(&done); > + } else { > + VisitForControl(expr->then_expression(), true_label_, false_label_, > NULL); > } > > __ bind(&false_case); > Index: src/version.cc > =================================================================== > --- src/version.cc (revision 5606) > +++ src/version.cc (working copy) > @@ -35,7 +35,7 @@ > #define MAJOR_VERSION 2 > #define MINOR_VERSION 3 > #define BUILD_NUMBER 11 > -#define PATCH_LEVEL 16 > +#define PATCH_LEVEL 17 > #define CANDIDATE_VERSION false > > // Define SONAME to have the SCons build the put a specific SONAME into > the > > > -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
