Reviewers: Vitaly,

Message:
This happened to be quite a big change... I'm split on whether or not it
actually brings enough benefit.

Vitaly and Yury, it'd be nice to hear your take on whether we should do this.

Description:
[Isolates] Make Factory a non-static class, share 'this' pointer with Isolate.

Introduce FACTORY-> for not perf-sensitive places where factory is used. It
pulls isolate from TLS.
Also use already existing isolate in runtime functions to pull factory.

Please review this at http://codereview.chromium.org/3678002/show

Affected files:
  M src/accessors.cc
  M src/api.h
  M src/api.cc
  M src/arm/code-stubs-arm.cc
  M src/arm/codegen-arm.cc
  M src/arm/regexp-macro-assembler-arm.cc
  M src/assembler.cc
  M src/bootstrapper.h
  M src/bootstrapper.cc
  M src/builtins.cc
  M src/code-stubs.cc
  M src/codegen.cc
  M src/compilation-cache.cc
  M src/compiler.cc
  M src/d8.cc
  M src/debug.cc
  M src/execution.cc
  M src/factory.h
  M src/factory.cc
  M src/full-codegen.cc
  M src/func-name-inferrer.h
  M src/func-name-inferrer.cc
  M src/handles.cc
  M src/heap-inl.h
  M src/heap.cc
  M src/ia32/builtins-ia32.cc
  M src/ia32/code-stubs-ia32.cc
  M src/ia32/codegen-ia32.cc
  M src/ia32/full-codegen-ia32.cc
  M src/ia32/ic-ia32.cc
  M src/ia32/macro-assembler-ia32.cc
  M src/ia32/regexp-macro-assembler-ia32.cc
  M src/ia32/stub-cache-ia32.cc
  M src/ia32/virtual-frame-ia32.cc
  M src/ic.cc
  M src/isolate.h
  M src/jsregexp.cc
  M src/liveedit.cc
  M src/messages.cc
  M src/mips/codegen-mips.cc
  M src/objects.cc
  M src/parser.cc
  M src/regexp-macro-assembler-irregexp.cc
  M src/rewriter.cc
  M src/runtime.cc
  M src/scopeinfo.cc
  M src/scopes.h
  M src/scopes.cc
  M src/string-stream.cc
  M src/stub-cache.cc
  M src/top.cc
  M src/variables.h
  M src/x64/builtins-x64.cc
  M src/x64/code-stubs-x64.cc
  M src/x64/codegen-x64.cc
  M src/x64/full-codegen-x64.cc
  M src/x64/macro-assembler-x64.cc
  M src/x64/regexp-macro-assembler-x64.cc
  M src/x64/stub-cache-x64.cc
  M src/x64/virtual-frame-x64.cc
  M test/cctest/test-alloc.cc
  M test/cctest/test-api.cc
  M test/cctest/test-assembler-arm.cc
  M test/cctest/test-assembler-ia32.cc
  M test/cctest/test-compiler.cc
  M test/cctest/test-cpu-profiler.cc
  M test/cctest/test-debug.cc
  M test/cctest/test-disasm-ia32.cc
  M test/cctest/test-func-name-inference.cc
  M test/cctest/test-heap-profiler.cc
  M test/cctest/test-heap.cc
  M test/cctest/test-log-stack-tracer.cc
  M test/cctest/test-mark-compact.cc
  M test/cctest/test-regexp.cc
  M test/cctest/test-serialize.cc
  M test/cctest/test-strings.cc


--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to