Reviewers: Rico, Description: Fix creation of an exception to avoid rare GC corner case.
Please review this at http://codereview.chromium.org/3782009/show SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M src/objects.cc A test/mjsunit/regress/regress-create-exception.js Index: src/objects.cc =================================================================== --- src/objects.cc (revision 5622) +++ src/objects.cc (working copy) @@ -6477,7 +6477,7 @@ // When we set the is_extensible flag to false we always force // the element into dictionary mode (and force them to stay there). if (!map()->is_extensible()) { - Handle<Object> number(Heap::NumberFromUint32(index)); + Handle<Object> number(Factory::NewNumberFromUint(index)); Handle<String> index_string(Factory::NumberToString(number)); Handle<Object> args[1] = { index_string }; return Top::Throw(*Factory::NewTypeError("object_not_extensible", Index: test/mjsunit/regress/regress-create-exception.js =================================================================== --- test/mjsunit/regress/regress-create-exception.js (revision 0) +++ test/mjsunit/regress/regress-create-exception.js (revision 0) @@ -0,0 +1,55 @@ +// Copyright 2010 the V8 project authors. All rights reserved. +// Redistribution and use in source and binary forms, with or without +// modification, are permitted provided that the following conditions are +// met: +// +// * Redistributions of source code must retain the above copyright +// notice, this list of conditions and the following disclaimer. +// * Redistributions in binary form must reproduce the above +// copyright notice, this list of conditions and the following +// disclaimer in the documentation and/or other materials provided +// with the distribution. +// * Neither the name of Google Inc. nor the names of its +// contributors may be used to endorse or promote products derived +// from this software without specific prior written permission. +// +// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS +// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT +// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR +// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT +// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, +// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT +// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, +// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY +// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT +// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE +// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + +// Flags: --max-new-space-size=128 + +// Check for GC bug constructing exceptions. +var v = [1, 2, 3, 4] + +Object.preventExtensions(v); + +function foo() { + var re = /2147483647/; + for (var i = 0; i < 7000; i++) { + var ok = 0; + try { + var j = 1; + for (var j = 0; j < i % 93; j++) { + j *= 1.123567; + } + v[0x7fffffff] = 0; + assertTrue(false); + return j; + } catch(e) { + ok = 1; + assertTrue(re.test(e)); + } + assertTrue(ok); + } +} + +foo(); -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
