http://codereview.chromium.org/3519017/diff/1/3 File test/cctest/test-strtod.cc (right):
http://codereview.chromium.org/3519017/diff/1/3#newcode19 test/cctest/test-strtod.cc:19: OS::StrNCpy(buffer, str, kBufferSize); On 2010/10/13 10:51:33, William Hesse wrote:
This doesn't guarantee a trailing null in buffer, so strlen call later
on can be
bad. Don't we have one that guarantees a trailing null?
What is the point of this copy? Can Strtod modify the input buffer?
Is it just
to remove the constness?
Why doesn't Strtod take a Vector<const char> anyway?
done. http://codereview.chromium.org/3519017/diff/1/3#newcode188 test/cctest/test-strtod.cc:188: CHECK_EQ(17e307, StrtodChar("17", 307)); On 2010/10/13 10:51:33, William Hesse wrote:
How about including right and left trim in these tests?
Done. http://codereview.chromium.org/3519017/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
