I just spotted a bug while writing a little documentation. The fix will come in
the next update of the patch.

Alexandre


http://codereview.chromium.org/3606009/diff/10001/11006
File src/arm/simulator-arm.cc (right):

http://codereview.chromium.org/3606009/diff/10001/11006#newcode392
src/arm/simulator-arm.cc:392: cur = reinterpret_cast<byte*>(value);
Does not do what is documented in the help. Changed to:
cur = reinterpret_cast<byte*>(sim_->get_pc());

http://codereview.chromium.org/3606009/diff/10001/11006#newcode394
src/arm/simulator-arm.cc:394: end = cur + (10 * Instr::kInstrSize);
Does not do what is documented in the help. Changed to:
end = cur + (value * Instr::kInstrSize);

http://codereview.chromium.org/3606009/diff/10001/11006#newcode515
src/arm/simulator-arm.cc:515: PrintF("disasm [<instructions>]\n");
I just found a bug for this command while writing some documentation.
The fix will come in the next update of the patch.

http://codereview.chromium.org/3606009/show

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to