Reviewers: Mads Ager, Description: Fix missing check for GC failure in number dictionary code.
Please review this at http://codereview.chromium.org/3781014/show SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M src/objects.cc Index: src/objects.cc =================================================================== --- src/objects.cc (revision 5634) +++ src/objects.cc (working copy) @@ -8591,7 +8591,9 @@ details = PropertyDetails(details.attributes(), details.type(), DetailsAt(entry).index()); - SetEntry(entry, NumberDictionaryShape::AsObject(key), value, details); + Object* okey = NumberDictionaryShape::AsObject(key); + if (okey->IsFailure()) return okey; + SetEntry(entry, okey, value, details); return this; } -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
