Revision: 5640
Author: [email protected]
Date: Mon Oct 18 05:16:38 2010
Log: Fix missing check for GC failure in number dictionary code.
Review URL: http://codereview.chromium.org/3781014
http://code.google.com/p/v8/source/detail?r=5640
Modified:
/branches/bleeding_edge/src/objects.cc
=======================================
--- /branches/bleeding_edge/src/objects.cc Fri Oct 15 00:54:20 2010
+++ /branches/bleeding_edge/src/objects.cc Mon Oct 18 05:16:38 2010
@@ -8591,7 +8591,9 @@
details = PropertyDetails(details.attributes(),
details.type(),
DetailsAt(entry).index());
- SetEntry(entry, NumberDictionaryShape::AsObject(key), value, details);
+ Object* object_key = NumberDictionaryShape::AsObject(key);
+ if (object_key->IsFailure()) return object_key;
+ SetEntry(entry, object_key, value, details);
return this;
}
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
