This is really cool! I'm looking forward to trying this out.

some minor drive-by comments:


http://codereview.chromium.org/3831002/diff/10001/11009
File src/platform-linux.cc (right):

http://codereview.chromium.org/3831002/diff/10001/11009#newcode407
src/platform-linux.cc:407: // Linux profiler built into the kernel logs
all mmap's with
The Linux profiler...

http://codereview.chromium.org/3831002/diff/10001/11015
File src/platform.h (right):

http://codereview.chromium.org/3831002/diff/10001/11015#newcode265
src/platform.h:265: // Support for profiler.  Notifies the external
profiling process
Support for _the_ profiler.

http://codereview.chromium.org/3831002/diff/10001/11015#newcode268
src/platform.h:268: // --never-compact) if accurate profiling is desired
.
Extra space before .

http://codereview.chromium.org/3831002/show

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to