Revision: 5660
Author: [email protected]
Date: Tue Oct 19 04:14:03 2010
Log: Change the StackGuard runtime function to take no arguments.
For some reason the StackGuard runtime function took a dummy argument
that it always ignored. Change it to take no arguments.
Review URL: http://codereview.chromium.org/3838003
http://code.google.com/p/v8/source/detail?r=5660
Modified:
/branches/bleeding_edge/src/arm/code-stubs-arm.cc
/branches/bleeding_edge/src/ia32/code-stubs-ia32.cc
/branches/bleeding_edge/src/runtime.cc
/branches/bleeding_edge/src/runtime.h
/branches/bleeding_edge/src/x64/code-stubs-x64.cc
=======================================
--- /branches/bleeding_edge/src/arm/code-stubs-arm.cc Mon Oct 18 07:04:28
2010
+++ /branches/bleeding_edge/src/arm/code-stubs-arm.cc Tue Oct 19 04:14:03
2010
@@ -2297,13 +2297,7 @@
void StackCheckStub::Generate(MacroAssembler* masm) {
- // Do tail-call to runtime routine. Runtime routines expect at least one
- // argument, so give it a Smi.
- __ mov(r0, Operand(Smi::FromInt(0)));
- __ push(r0);
- __ TailCallRuntime(Runtime::kStackGuard, 1, 1);
-
- __ Ret();
+ __ TailCallRuntime(Runtime::kStackGuard, 0, 1);
}
=======================================
--- /branches/bleeding_edge/src/ia32/code-stubs-ia32.cc Mon Oct 18 07:04:28
2010
+++ /branches/bleeding_edge/src/ia32/code-stubs-ia32.cc Tue Oct 19 04:14:03
2010
@@ -2964,16 +2964,7 @@
void StackCheckStub::Generate(MacroAssembler* masm) {
- // Because builtins always remove the receiver from the stack, we
- // have to fake one to avoid underflowing the stack. The receiver
- // must be inserted below the return address on the stack so we
- // temporarily store that in a register.
- __ pop(eax);
- __ push(Immediate(Smi::FromInt(0)));
- __ push(eax);
-
- // Do tail-call to runtime routine.
- __ TailCallRuntime(Runtime::kStackGuard, 1, 1);
+ __ TailCallRuntime(Runtime::kStackGuard, 0, 1);
}
=======================================
--- /branches/bleeding_edge/src/runtime.cc Mon Oct 18 05:58:56 2010
+++ /branches/bleeding_edge/src/runtime.cc Tue Oct 19 04:14:03 2010
@@ -6703,7 +6703,7 @@
static Object* Runtime_StackGuard(Arguments args) {
- ASSERT(args.length() == 1);
+ ASSERT(args.length() == 0);
// First check if this is a real stack overflow.
if (StackGuard::IsStackOverflow()) {
=======================================
--- /branches/bleeding_edge/src/runtime.h Thu Sep 23 02:15:26 2010
+++ /branches/bleeding_edge/src/runtime.h Tue Oct 19 04:14:03 2010
@@ -267,7 +267,7 @@
F(Throw, 1, 1) \
F(ReThrow, 1, 1) \
F(ThrowReferenceError, 1, 1) \
- F(StackGuard, 1, 1) \
+ F(StackGuard, 0, 1) \
F(PromoteScheduledException, 0, 1) \
\
/* Contexts */ \
=======================================
--- /branches/bleeding_edge/src/x64/code-stubs-x64.cc Mon Oct 18 07:04:28
2010
+++ /branches/bleeding_edge/src/x64/code-stubs-x64.cc Tue Oct 19 04:14:03
2010
@@ -2394,16 +2394,7 @@
void StackCheckStub::Generate(MacroAssembler* masm) {
- // Because builtins always remove the receiver from the stack, we
- // have to fake one to avoid underflowing the stack. The receiver
- // must be inserted below the return address on the stack so we
- // temporarily store that in a register.
- __ pop(rax);
- __ Push(Smi::FromInt(0));
- __ push(rax);
-
- // Do tail-call to runtime routine.
- __ TailCallRuntime(Runtime::kStackGuard, 1, 1);
+ __ TailCallRuntime(Runtime::kStackGuard, 0, 1);
}
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
