Reviewers: Erik Corry,

http://codereview.chromium.org/3844006/diff/1/2
File src/arm/regexp-macro-assembler-arm.cc (right):

http://codereview.chromium.org/3844006/diff/1/2#newcode930
src/arm/regexp-macro-assembler-arm.cc:930: Label after_position;
There is no NearLabel for ARM.

http://codereview.chromium.org/3844006/diff/1/2#newcode932
src/arm/regexp-macro-assembler-arm.cc:932: __ b(ge, &after_position);
Comparison must be signed, since either value can be zero as well as
negative.

Description:
Limit end-anchored regexps to testing end of string where possible.

Please review this at http://codereview.chromium.org/3844006/show

Affected files:
  M src/arm/regexp-macro-assembler-arm.h
  M src/arm/regexp-macro-assembler-arm.cc
  M src/ast.h
  M src/ast.cc
  M src/bytecodes-irregexp.h
  M src/ia32/regexp-macro-assembler-ia32.h
  M src/ia32/regexp-macro-assembler-ia32.cc
  M src/interpreter-irregexp.cc
  src/jsregexp.cc
  M src/regexp-macro-assembler-irregexp.h
  M src/regexp-macro-assembler-irregexp.cc
  M src/regexp-macro-assembler-tracer.h
  M src/regexp-macro-assembler-tracer.cc
  M src/regexp-macro-assembler.h
  M src/x64/regexp-macro-assembler-x64.h
  M src/x64/regexp-macro-assembler-x64.cc
  M test/mjsunit/regexp.js


--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to