lgtm and thanks.

yours,
anton.

On Thu, Oct 21, 2010 at 10:29 AM,  <[email protected]> wrote:
> Reviewers: antonm,
>
> Description:
> Fix compilation on Windows on the 2.4 branch after revert of aggresive
> garbage collection when close to OOM patch.
>
> [email protected]
>
> Please review this at http://codereview.chromium.org/3966003/show
>
> SVN Base: http://v8.googlecode.com/svn/branches/2.4/
>
> Affected files:
>  M     src/heap.cc
>  M     src/version.cc
>
>
> Index: src/heap.cc
> ===================================================================
> --- src/heap.cc (revision 5680)
> +++ src/heap.cc (working copy)
> @@ -691,7 +691,7 @@
>
>     UpdateSurvivalRateTrend(start_new_space_size);
>
> -    int old_gen_size = PromotedSpaceSize();
> +    intptr_t old_gen_size = PromotedSpaceSize();
>     old_gen_promotion_limit_ =
>         old_gen_size + Max(kMinimumPromotionLimit, old_gen_size / 3);
>     old_gen_allocation_limit_ =
> Index: src/version.cc
> ===================================================================
> --- src/version.cc      (revision 5680)
> +++ src/version.cc      (working copy)
> @@ -35,7 +35,7 @@
>  #define MAJOR_VERSION     2
>  #define MINOR_VERSION     4
>  #define BUILD_NUMBER      9
> -#define PATCH_LEVEL       7
> +#define PATCH_LEVEL       8
>  #define CANDIDATE_VERSION false
>
>  // Define SONAME to have the SCons build the put a specific SONAME into the
>
>
>

-- 
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to