Reviewers: Søren Gjesse, Description: Use return value from fwrite in log.cc to please compilers.
BUG=453 Please review this at http://codereview.chromium.org/4002005/show SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M src/log.cc M src/platform-macos.cc Index: src/log.cc =================================================================== --- src/log.cc (revision 5693) +++ src/log.cc (working copy) @@ -1378,8 +1378,10 @@ void Logger::LowLevelCodeCreateEvent(Code* code, LogMessageBuilder* msg) { if (!FLAG_ll_prof || Log::output_code_handle_ == NULL) return; int pos = static_cast<int>(ftell(Log::output_code_handle_)); - fwrite(code->instruction_start(), 1, code->instruction_size(), - Log::output_code_handle_); + int rv = fwrite(code->instruction_start(), 1, code->instruction_size(), + Log::output_code_handle_); + ASSERT(static_cast<size_t>(code->instruction_size()) == rv); + USE(rv); msg->Append(",%d", pos); } Index: src/platform-macos.cc =================================================================== --- src/platform-macos.cc (revision 5693) +++ src/platform-macos.cc (working copy) @@ -206,7 +206,11 @@ void* initial) { FILE* file = fopen(name, "w+"); if (file == NULL) return NULL; - fwrite(initial, size, 1, file); + int result = fwrite(initial, size, 1, file); + if (result < 1) { + fclose(file); + return NULL; + } void* memory = mmap(0, size, PROT_READ | PROT_WRITE, MAP_SHARED, fileno(file), 0); return new PosixMemoryMappedFile(file, memory, size); -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
