LGTM
http://codereview.chromium.org/4000007/diff/1/2 File src/platform-linux.cc (right): http://codereview.chromium.org/4000007/diff/1/2#newcode807 src/platform-linux.cc:807: for ( ; sampler_->IsActive(); usleep(sampler_->interval_ * 1000 - 100)) { On 2010/10/26 10:01:58, Michail Naganov wrote:
On 2010/10/25 16:57:25, Vitaly wrote: > I think "while" loop is more readable here. Also we should check
that usleep
> returns 0 or EINTR, everything else is a bug.
Converted to while. But I'm not sure what to do, if usleep fails.
Something like: int ret = usleep(...); ASSERT(ret == 0 || ret == EINTR); USE(ret); // To avoid release mode warnings. http://codereview.chromium.org/4000007/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
