LGTM. Pretty neat.
http://codereview.chromium.org/4189001/diff/3001/4002 File src/runtime.cc (right): http://codereview.chromium.org/4189001/diff/3001/4002#newcode4644 src/runtime.cc:4644: // the range (m, n). All the other bits in the result are cleared. maybe follow more standard [;) intervals http://codereview.chromium.org/4189001/diff/3001/4002#newcode4647 src/runtime.cc:4647: // Requires: the input word and the boundaries must be ascii. I think ascii requires additional clarification. And maybe it is better to formulate it as a restriction on the range of values http://codereview.chromium.org/4189001/diff/3001/4002#newcode4684 src/runtime.cc:4684: while (src <= limit - sizeof(uintptr_t)) { Maybe convert src to uintptr_t*? That would allow to get rid of the casts and sizeof's. http://codereview.chromium.org/4189001/diff/3001/4003 File test/mjsunit/string-case.js (right): http://codereview.chromium.org/4189001/diff/3001/4003#newcode55 test/mjsunit/string-case.js:55: function randomGenerator(i, j) { I don't think you have to declare unused arguments here (at least JS allows that). I find them somewhat misleading, but up to you. http://codereview.chromium.org/4189001/diff/3001/4003#newcode77 test/mjsunit/string-case.js:77: test(generator, i + j); I am slightly concerned that string pattern for this case is too regular, for example, you only cases when string starts with lower case chars (0 or more) than has a region of upper case chars and again lower case. Maybe I'd only leave pseudo-random generator, but up to you. http://codereview.chromium.org/4189001/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
