Reviewers: Erik Corry,
Description:
Remove all remaining code related to exposing C-frames to the JavaScript
debugger
BUG=906
Please review this at http://codereview.chromium.org/4104009/show
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M src/debug-debugger.js
M src/runtime.h
M src/runtime.cc
Index: src/debug-debugger.js
===================================================================
--- src/debug-debugger.js (revision 5713)
+++ src/debug-debugger.js (working copy)
@@ -897,10 +897,6 @@
return new FrameMirror(this.break_id, opt_index);
};
-ExecutionState.prototype.cframesValue = function(opt_from_index,
opt_to_index) {
- return %GetCFrames(this.break_id);
-};
-
ExecutionState.prototype.setSelectedFrame = function(index) {
var i = %ToNumber(index);
if (i < 0 || i >= this.frameCount()) throw new Error('Illegal frame
index.');
@@ -1751,11 +1747,6 @@
};
-DebugCommandProcessor.prototype.backtracec = function(cmd, args) {
- return this.exec_state_.cframesValue();
-};
-
-
DebugCommandProcessor.prototype.frameRequest_ = function(request,
response) {
// No frames no source.
if (this.exec_state_.frameCount() == 0) {
@@ -2205,30 +2196,7 @@
return r;
};
-DebugCommandProcessor.prototype.formatCFrames = function(cframes_value) {
- var result = "";
- if (cframes_value == null || cframes_value.length == 0) {
- result += "(stack empty)";
- } else {
- for (var i = 0; i < cframes_value.length; ++i) {
- if (i != 0) result += "\n";
- result += this.formatCFrame(cframes_value[i]);
- }
- }
- return result;
-};
-
-DebugCommandProcessor.prototype.formatCFrame = function(cframe_value) {
- var result = "";
- result += "0x" + NumberToHex8Str(cframe_value.address);
- if (!IS_UNDEFINED(cframe_value.text)) {
- result += " " + cframe_value.text;
- }
- return result;
-}
-
-
/**
* Convert an Object to its debugger protocol representation. The
representation
* may be serilized to a JSON object using JSON.stringify().
Index: src/runtime.cc
===================================================================
--- src/runtime.cc (revision 5713)
+++ src/runtime.cc (working copy)
@@ -8881,12 +8881,6 @@
}
-static MaybeObject* Runtime_GetCFrames(Arguments args) {
- // See bug 906.
- return Heap::undefined_value();
-}
-
-
static MaybeObject* Runtime_GetThreadCount(Arguments args) {
HandleScope scope;
ASSERT(args.length() == 1);
Index: src/runtime.h
===================================================================
--- src/runtime.h (revision 5713)
+++ src/runtime.h (working copy)
@@ -322,7 +322,6 @@
F(GetScopeCount, 2, 1) \
F(GetScopeDetails, 3, 1) \
F(DebugPrintScopes, 0, 1) \
- F(GetCFrames, 1, 1) \
F(GetThreadCount, 1, 1) \
F(GetThreadDetails, 2, 1) \
F(SetDisableBreak, 1, 1) \
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
