LGTM
http://codereview.chromium.org/4146006/diff/1/6 File src/parser.cc (left): http://codereview.chromium.org/4146006/diff/1/6#oldcode1 src/parser.cc:1: // Copyright 2010 the V8 project authors. All rights reserved. Whoops. http://codereview.chromium.org/4146006/diff/1/7 File src/parser.h (right): http://codereview.chromium.org/4146006/diff/1/7#newcode201 src/parser.h:201: class BufferedZoneList { Could you add a comment here about the buffering nature? I know you just moved this code, but a class comment would be nice. http://codereview.chromium.org/4146006/diff/1/7#newcode226 src/parser.h:226: if (list_ != NULL && list_->length() > 0) Please uses braces. http://codereview.chromium.org/4146006/diff/1/7#newcode288 src/parser.h:288: private: Could you add a blank line before "private:" http://codereview.chromium.org/4146006/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
