LGTM. My main complain is names.
http://codereview.chromium.org/4117010/diff/1/2 File include/v8.h (right): http://codereview.chromium.org/4117010/diff/1/2#newcode1798 include/v8.h:1798: inline Arguments(internal::Object** extra, any chances for better names? for example args might be a better name for values, but alas I don't have any good idea for extra. http://codereview.chromium.org/4117010/diff/1/3 File src/apiutils.h (right): http://codereview.chromium.org/4117010/diff/1/3#newcode48 src/apiutils.h:48: // a pointer to the last element of 3-ements array controlled by GC. nit: 3-e<le>ments http://codereview.chromium.org/4117010/diff/1/3#newcode49 src/apiutils.h:49: static void PrepareArgumentsData(internal::Object** data, maybe rename data to args or extra and call_data to data? http://codereview.chromium.org/4117010/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
