Drive by, only because I'm passionate about the #else comment.
http://codereview.chromium.org/4320004/diff/1/3 File include/v8stdint.h (right): http://codereview.chromium.org/4320004/diff/1/3#newcode1 include/v8stdint.h:1: // Copyright 2007-2009 the V8 project authors. All rights reserved. 2010? http://codereview.chromium.org/4320004/diff/1/3#newcode30 include/v8stdint.h:30: #include <stdio.h> Is there a reason not to put this inside the include guard? http://codereview.chromium.org/4320004/diff/1/3#newcode47 include/v8stdint.h:47: #else // _WIN32 && !__MINGW32__ The existing code is split on whether the comment after the #else describes what is true for the if branch, or what is true for the else branch (and since we don't have any standard, the comment is always useless, imo). You could nicely dodge the issue by getting rid of the comment since even my phone can show 12 lines. http://codereview.chromium.org/4320004/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
