Cute. One question below.

http://codereview.chromium.org/4247004/diff/1/3
File src/utils.h (right):

http://codereview.chromium.org/4247004/diff/1/3#newcode53
src/utils.h:53: static inline int WhichPowerOf2(T x) {
Do we only ever use this on 32-bit integers? It is a template methods so
nothing prevents us from calling it with an intptr_t on 64-bit.

If we only use this on 32-bit integers could we just change the type to
int to reflect that.

http://codereview.chromium.org/4247004/show

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to