LGTM Thanks for refactoring duplicated code while fixing this bug.
http://codereview.chromium.org/4469002/diff/1/2 File src/arm/assembler-arm.cc (right): http://codereview.chromium.org/4469002/diff/1/2#newcode999 src/arm/assembler-arm.cc:999: positions_recorder()->WriteRecordedPositions(); Why not just positions_recorder_. instead of positions_recorder()->? http://codereview.chromium.org/4469002/diff/1/7 File src/assembler.h (right): http://codereview.chromium.org/4469002/diff/1/7#newcode590 src/assembler.h:590: enum PositionRecordingType { FORCED_POSITION, NORMAL_POSITION }; Thanks for using an enum instead of a boolean. http://codereview.chromium.org/4469002/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
