[v8-dev] Fix presubmit errors introduced by r5768. (issue4409003)

Thu, 04 Nov 2010 08:27:22 -0700 

Reviewers: Søren Gjesse,

Description:
Fix presubmit errors introduced by r5768.

Please review this at http://codereview.chromium.org/4409003/show

SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge

Affected files:
  M src/arm/assembler-arm.h
  M src/arm/full-codegen-arm.cc
  M src/assembler.h
  M src/ia32/full-codegen-ia32.cc
  M src/x64/full-codegen-x64.cc


Index: src/arm/assembler-arm.h
diff --git a/src/arm/assembler-arm.h b/src/arm/assembler-arm.h
index de9dbf3a84d7a4ebd5d069fea084159f06746e79..98eaf9bad41ebe68ef2dac417e9b102d0a7b2cda 100644 
--- a/src/arm/assembler-arm.h
+++ b/src/arm/assembler-arm.h
@@ -1289,7 +1289,7 @@ class Assembler : public Malloced {

 class EnsureSpace BASE_EMBEDDED {
  public:
-  EnsureSpace(Assembler* assembler) {
+  explicit EnsureSpace(Assembler* assembler) {
     assembler->CheckBuffer();
   }
 };
Index: src/arm/full-codegen-arm.cc
diff --git a/src/arm/full-codegen-arm.cc b/src/arm/full-codegen-arm.cc
index 2b2d50b6541f062b5bd5a0caa335a95ff81962b1..bf27d0c7fee1067745e97594ea8d1a2dcf5a5aa0 100644 
--- a/src/arm/full-codegen-arm.cc
+++ b/src/arm/full-codegen-arm.cc
@@ -1766,7 +1766,6 @@ void FullCodeGenerator::VisitCall(Call* expr) {
     int arg_count = args->length();
{ PreserveStatementPositionScope pos_scope(masm()->positions_recorder()); 
-
       VisitForStackValue(fun);
       __ LoadRoot(r2, Heap::kUndefinedValueRootIndex);
       __ push(r2);  // Reserved receiver slot.
Index: src/assembler.h
diff --git a/src/assembler.h b/src/assembler.h
index b71c5704daa0f3684448a13915a21794f7ac9976..09159fed08ee7babde1bfd27d51af5ee117209c5 100644 
--- a/src/assembler.h
+++ b/src/assembler.h
@@ -629,7 +629,7 @@ class PositionsRecorder BASE_EMBEDDED {

 class PreserveStatementPositionScope BASE_EMBEDDED {
  public:
-  PreserveStatementPositionScope(PositionsRecorder* positions_recorder)
+ explicit PreserveStatementPositionScope(PositionsRecorder* positions_recorder) 
       : positions_recorder_(positions_recorder),
statement_position_(positions_recorder->current_statement_position()) {} 

Index: src/ia32/full-codegen-ia32.cc
diff --git a/src/ia32/full-codegen-ia32.cc b/src/ia32/full-codegen-ia32.cc
index 74526686f3d02fbd659422c3fdb8ef7b0f61012f..1ea719d7133e4a137568afd841ce92d1037f1e14 100644 
--- a/src/ia32/full-codegen-ia32.cc
+++ b/src/ia32/full-codegen-ia32.cc
@@ -2072,7 +2072,8 @@ void FullCodeGenerator::VisitCall(Call* expr) {
     int arg_count = args->length();
{ PreserveStatementPositionScope pos_scope(masm()->positions_recorder()); 
       VisitForStackValue(fun);
- __ push(Immediate(Factory::undefined_value())); // Reserved receiver slot. 
+      // Reserved receiver slot.
+      __ push(Immediate(Factory::undefined_value()));

       // Push the arguments.
       for (int i = 0; i < arg_count; i++) {
Index: src/x64/full-codegen-x64.cc
diff --git a/src/x64/full-codegen-x64.cc b/src/x64/full-codegen-x64.cc
index 96a0d93c5ae34bc02ee8d668ba8141c0e9055b38..00ea684582abd682da6d8ecf1e22a3e9b210f4e1 100644 
--- a/src/x64/full-codegen-x64.cc
+++ b/src/x64/full-codegen-x64.cc
@@ -1796,7 +1796,6 @@ void FullCodeGenerator::VisitCall(Call* expr) {
     ZoneList<Expression*>* args = expr->arguments();
     int arg_count = args->length();
{ PreserveStatementPositionScope pos_scope(masm()->positions_recorder()); 
-
       VisitForStackValue(fun);
__ PushRoot(Heap::kUndefinedValueRootIndex); // Reserved receiver slot. 



--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to