Revision: 5770
Author: [email protected]
Date: Thu Nov 4 08:39:06 2010
Log: Fix presubmit errors introduced by r5768.
Review URL: http://codereview.chromium.org/4409003
http://code.google.com/p/v8/source/detail?r=5770
Modified:
/branches/bleeding_edge/src/arm/assembler-arm.h
/branches/bleeding_edge/src/arm/full-codegen-arm.cc
/branches/bleeding_edge/src/assembler.h
/branches/bleeding_edge/src/ia32/full-codegen-ia32.cc
/branches/bleeding_edge/src/x64/full-codegen-x64.cc
=======================================
--- /branches/bleeding_edge/src/arm/assembler-arm.h Thu Nov 4 08:30:04 2010
+++ /branches/bleeding_edge/src/arm/assembler-arm.h Thu Nov 4 08:39:06 2010
@@ -1290,7 +1290,7 @@
class EnsureSpace BASE_EMBEDDED {
public:
- EnsureSpace(Assembler* assembler) {
+ explicit EnsureSpace(Assembler* assembler) {
assembler->CheckBuffer();
}
};
=======================================
--- /branches/bleeding_edge/src/arm/full-codegen-arm.cc Thu Nov 4 08:12:03
2010
+++ /branches/bleeding_edge/src/arm/full-codegen-arm.cc Thu Nov 4 08:39:06
2010
@@ -1766,7 +1766,6 @@
int arg_count = args->length();
{ PreserveStatementPositionScope
pos_scope(masm()->positions_recorder());
-
VisitForStackValue(fun);
__ LoadRoot(r2, Heap::kUndefinedValueRootIndex);
__ push(r2); // Reserved receiver slot.
=======================================
--- /branches/bleeding_edge/src/assembler.h Thu Nov 4 08:12:03 2010
+++ /branches/bleeding_edge/src/assembler.h Thu Nov 4 08:39:06 2010
@@ -629,7 +629,7 @@
class PreserveStatementPositionScope BASE_EMBEDDED {
public:
- PreserveStatementPositionScope(PositionsRecorder* positions_recorder)
+ explicit PreserveStatementPositionScope(PositionsRecorder*
positions_recorder)
: positions_recorder_(positions_recorder),
statement_position_(positions_recorder->current_statement_position()) {}
=======================================
--- /branches/bleeding_edge/src/ia32/full-codegen-ia32.cc Thu Nov 4
08:12:03 2010
+++ /branches/bleeding_edge/src/ia32/full-codegen-ia32.cc Thu Nov 4
08:39:06 2010
@@ -2072,7 +2072,8 @@
int arg_count = args->length();
{ PreserveStatementPositionScope
pos_scope(masm()->positions_recorder());
VisitForStackValue(fun);
- __ push(Immediate(Factory::undefined_value())); // Reserved
receiver slot.
+ // Reserved receiver slot.
+ __ push(Immediate(Factory::undefined_value()));
// Push the arguments.
for (int i = 0; i < arg_count; i++) {
=======================================
--- /branches/bleeding_edge/src/x64/full-codegen-x64.cc Thu Nov 4 08:12:03
2010
+++ /branches/bleeding_edge/src/x64/full-codegen-x64.cc Thu Nov 4 08:39:06
2010
@@ -1796,7 +1796,6 @@
ZoneList<Expression*>* args = expr->arguments();
int arg_count = args->length();
{ PreserveStatementPositionScope
pos_scope(masm()->positions_recorder());
-
VisitForStackValue(fun);
__ PushRoot(Heap::kUndefinedValueRootIndex); // Reserved receiver
slot.
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
