LGTM
http://codereview.chromium.org/4576001/diff/1/7 File src/scanner-base.h (right): http://codereview.chromium.org/4576001/diff/1/7#newcode159 src/scanner-base.h:159: Excessive spacing. http://codereview.chromium.org/4576001/diff/1/13 File tools/v8.xcodeproj/project.pbxproj (right): http://codereview.chromium.org/4576001/diff/1/13#newcode118 tools/v8.xcodeproj/project.pbxproj:118: 89A88E1B0E71A69D0043BA31 /* scanner-base.cc in Sources */ = {isa = PBXBuildFile; fileRef = 897FF1730E719B8F00D62E90 /* scanner-base.cc */; }; Did you just reuse an ID here? That will not fly. Better to not mess with this file in that case. http://codereview.chromium.org/4576001/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
