LGTM
http://codereview.chromium.org/4456002/diff/58002/79006 File src/ia32/stub-cache-ia32.cc (right): http://codereview.chromium.org/4456002/diff/58002/79006#newcode417 src/ia32/stub-cache-ia32.cc:417: static const int kArgumentsImplicitItems = 3; I would rather prefer to mention fast api call in the name, than implicit args. http://codereview.chromium.org/4456002/diff/58002/79006#newcode443 src/ia32/stub-cache-ia32.cc:443: // -- esp[12] : first fast api call extra argument to forget about troubles you can change 12 into something like 4 * kArgumentsImplicitItems http://codereview.chromium.org/4456002/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
