Revision: 5800
Author: [email protected]
Date: Wed Nov 10 01:20:08 2010
Log: Fix executable memory setting and fix test.
Review URL: http://codereview.chromium.org/4764002
http://code.google.com/p/v8/source/detail?r=5800

Modified:
 /branches/bleeding_edge/src/heap.cc
 /branches/bleeding_edge/src/spaces.cc
 /branches/bleeding_edge/test/cctest/test-mark-compact.cc

=======================================
--- /branches/bleeding_edge/src/heap.cc Wed Nov 10 00:38:42 2010
+++ /branches/bleeding_edge/src/heap.cc Wed Nov 10 01:20:08 2010
@@ -4346,7 +4346,7 @@

   if (max_old_gen_size > 0) max_old_generation_size_ = max_old_gen_size;
   if (max_executable_size > 0) {
-    max_executable_size_ = RoundUp(max_executable_size_, Page::kPageSize);
+    max_executable_size_ = RoundUp(max_executable_size, Page::kPageSize);
   }

// The new space size must be a power of two to support single-bit testing
=======================================
--- /branches/bleeding_edge/src/spaces.cc       Wed Nov 10 00:38:42 2010
+++ /branches/bleeding_edge/src/spaces.cc       Wed Nov 10 01:20:08 2010
@@ -270,9 +270,9 @@
// -----------------------------------------------------------------------------
 // MemoryAllocator
 //
-intptr_t MemoryAllocator::capacity_   = 0;
+intptr_t MemoryAllocator::capacity_ = 0;
 intptr_t MemoryAllocator::capacity_executable_ = 0;
-intptr_t MemoryAllocator::size_       = 0;
+intptr_t MemoryAllocator::size_ = 0;
 intptr_t MemoryAllocator::size_executable_ = 0;

 List<MemoryAllocator::MemoryAllocationCallbackRegistration>
=======================================
--- /branches/bleeding_edge/test/cctest/test-mark-compact.cc Wed Nov 10 00:38:42 2010 +++ /branches/bleeding_edge/test/cctest/test-mark-compact.cc Wed Nov 10 01:20:08 2010
@@ -75,7 +75,7 @@
   // from new space.
   FLAG_gc_global = true;
   FLAG_always_compact = true;
-  Heap::ConfigureHeap(2*256*KB, 4*MB, 0);
+  Heap::ConfigureHeap(2*256*KB, 4*MB, 4*MB);

   InitializeVM();

@@ -101,7 +101,7 @@


 TEST(NoPromotion) {
-  Heap::ConfigureHeap(2*256*KB, 4*MB, 0);
+  Heap::ConfigureHeap(2*256*KB, 4*MB, 4*MB);

   // Test the situation that some objects in new space are promoted to
   // the old space

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to