LGTM
http://codereview.chromium.org/5005001/diff/1/src/allocation.cc File src/allocation.cc (right): http://codereview.chromium.org/5005001/diff/1/src/allocation.cc#newcode90 src/allocation.cc:90: memcpy(result, str, length); do we know that kCharSize is always 1? http://codereview.chromium.org/5005001/diff/1/src/api.cc File src/api.cc (right): http://codereview.chromium.org/5005001/diff/1/src/api.cc#newcode117 src/api.cc:117: Not this change, but remove one line here http://codereview.chromium.org/5005001/diff/1/src/v8globals.h File src/v8globals.h (right): http://codereview.chromium.org/5005001/diff/1/src/v8globals.h#newcode1 src/v8globals.h:1: // Copyright 2006-2009 the V8 project authors. All rights reserved. Change to "// Copyright 2010" ..... (at least this is how we seem to do this now a days http://codereview.chromium.org/5005001/diff/1/src/v8globals.h#newcode38 src/v8globals.h:38: I am assuming that all of the below is simply yank-paste from globals.h http://codereview.chromium.org/5005001/diff/1/src/virtual-frame.h File src/virtual-frame.h (right): http://codereview.chromium.org/5005001/diff/1/src/virtual-frame.h#newcode47 src/virtual-frame.h:47: #include "utils.h" Move includes up before platform specific includes? (and merge alphabetically) http://codereview.chromium.org/5005001/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
