Thanks!
http://codereview.chromium.org/5139002/diff/1/src/profile-generator.cc File src/profile-generator.cc (right): http://codereview.chromium.org/5139002/diff/1/src/profile-generator.cc#newcode1476 src/profile-generator.cc:1476: const uint64_t HeapObjectsMap::kGcRootsObjectId = 1; On 2010/11/18 08:14:54, Søren Gjesse wrote:
Please add kNumReservedObjectsIds = 2 (maybe you can find a better
name) and use
instead of 2 below.
OK, I've introduced kFirstAvailableObjectId. http://codereview.chromium.org/5139002/diff/1/src/profile-generator.cc#newcode1863 src/profile-generator.cc:1863: On 2010/11/18 08:14:54, Søren Gjesse wrote:
Add empty line.
Done. http://codereview.chromium.org/5139002/diff/1/src/profile-generator.cc#newcode1914 src/profile-generator.cc:1914: HeapObjectsSet* knownReferences = NULL) On 2010/11/18 08:14:54, Søren Gjesse wrote:
knownReferences -> known_references
Done. http://codereview.chromium.org/5139002/diff/1/src/profile-generator.h File src/profile-generator.h (right): http://codereview.chromium.org/5139002/diff/1/src/profile-generator.h#newcode703 src/profile-generator.h:703: static HeapObject *const kInternalRootObject; On 2010/11/18 08:14:54, Søren Gjesse wrote:
Move * closer to HeapObject.
Done. http://codereview.chromium.org/5139002/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
