LGTM On Thu, Nov 18, 2010 at 2:18 PM, <[email protected]> wrote: > Reviewers: SeRya, antonm, > > Description: > Don't return false from CompileCallInterceptor which returns a > MaybeObject*. Instead return the failure which will be handled > correctly by the caller. This code would lead to a crash if ever > executed. > > > > Please review this at http://codereview.chromium.org/5182006/ > > SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ > > Affected files: > M src/ia32/stub-cache-ia32.cc > > > Index: src/ia32/stub-cache-ia32.cc > =================================================================== > --- src/ia32/stub-cache-ia32.cc (revision 5842) > +++ src/ia32/stub-cache-ia32.cc (working copy) > @@ -2318,7 +2318,7 @@ > &miss, > &failure); > if (!success) { > - return false; > + return failure; > } > > // Restore receiver. > > >
-- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
