LGTM
http://codereview.chromium.org/5188009/diff/1/src/parser.cc File src/parser.cc (right): http://codereview.chromium.org/5188009/diff/1/src/parser.cc#newcode4639 src/parser.cc:4639: // Create a Scannerfor the preparser to use as input, and preparse the source. Scannerfor -> Scanner for http://codereview.chromium.org/5188009/diff/1/src/parser.cc#newcode4644 src/parser.cc:4644: int kLiteralFlags) { kLiteralFlags -> literal_flags. http://codereview.chromium.org/5188009/diff/1/src/parser.cc#newcode4644 src/parser.cc:4644: int kLiteralFlags) { Instead of passing flags could the PartialParserRecorder have a method for requesting this - or does that not make any sense? http://codereview.chromium.org/5188009/diff/1/src/parser.cc#newcode4673 src/parser.cc:4673: const int kNoLiteralsFlag = 0; Shouldn't this constant be part of the enum in the JavaScriptScanner? http://codereview.chromium.org/5188009/diff/1/src/scanner-base.h File src/scanner-base.h (right): http://codereview.chromium.org/5188009/diff/1/src/scanner-base.h#newcode339 src/scanner-base.h:339: // More specialized literal scope. More specialized - in what sense? http://codereview.chromium.org/5188009/diff/1/src/scanner.h File src/scanner.h (right): http://codereview.chromium.org/5188009/diff/1/src/scanner.h#newcode120 src/scanner.h:120: static const int kAllLiteralsFlag = kLiteralNumber | kLiteralString This constant should also be in the enum. http://codereview.chromium.org/5188009/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
