Revision: 5865 Author: [email protected] Date: Fri Nov 19 04:36:39 2010 Log: Made some functions virtual that were previously hit by templating. Currently means that preparsing doesn't record/export symbol data.
Review URL: http://codereview.chromium.org/5122007 http://code.google.com/p/v8/source/detail?r=5865 Modified: /branches/bleeding_edge/src/parser.h ======================================= --- /branches/bleeding_edge/src/parser.h Thu Nov 18 05:07:02 2010 +++ /branches/bleeding_edge/src/parser.h Fri Nov 19 04:36:39 2010 @@ -181,6 +181,7 @@ class PartialParserRecorder { public: PartialParserRecorder(); + virtual ~PartialParserRecorder() {} void LogFunction(int start, int end, int literals, int properties) { function_store_.Add(start); @@ -189,7 +190,7 @@ function_store_.Add(properties); } - void LogSymbol(int start, const char* symbol, int length) { } + virtual void LogSymbol(int start, const char* symbol, int length) { } // Logs an error message and marks the log as containing an error. // Further logging will be ignored, and ExtractData will return a vector @@ -212,7 +213,7 @@ const char* message, Vector<const char*> args); - Vector<unsigned> ExtractData(); + virtual Vector<unsigned> ExtractData(); void PauseRecording() { pause_count_++; @@ -253,14 +254,15 @@ class CompleteParserRecorder: public PartialParserRecorder { public: CompleteParserRecorder(); + virtual ~CompleteParserRecorder() { } void LogSymbol(int start, Vector<const char> literal); - void LogSymbol(int start, const char* symbol, int length) { + virtual void LogSymbol(int start, const char* symbol, int length) { LogSymbol(start, Vector<const char>(symbol, length)); } - Vector<unsigned> ExtractData(); + virtual Vector<unsigned> ExtractData(); int symbol_position() { return symbol_store_.size(); } int symbol_ids() { return symbol_id_; } -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
