LGTM with minor issues fixed.
http://codereview.chromium.org/5140002/diff/12001/src/arm/assembler-arm.h File src/arm/assembler-arm.h (right): http://codereview.chromium.org/5140002/diff/12001/src/arm/assembler-arm.h#newcode1186 src/arm/assembler-arm.h:1186: static bool IsNop(Instr instr, int = NON_MARKING_NOP); Missing argument name. http://codereview.chromium.org/5140002/diff/12001/src/arm/macro-assembler-arm.h File src/arm/macro-assembler-arm.h (right): http://codereview.chromium.org/5140002/diff/12001/src/arm/macro-assembler-arm.h#newcode345 src/arm/macro-assembler-arm.h:345: // Return <n> if we have a mov rn rn, else return -1. How about assigning this to a local variable type and add ASSERT(type == -1 || IsNop(type)); http://codereview.chromium.org/5140002/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
