LGTM.
http://codereview.chromium.org/5443001/diff/1/src/runtime.cc File src/runtime.cc (right): http://codereview.chromium.org/5443001/diff/1/src/runtime.cc#newcode4618 src/runtime.cc:4618: if (sizeof(Char) > 1) { 1u? http://codereview.chromium.org/5443001/diff/1/src/runtime.cc#newcode4632 src/runtime.cc:4632: // TODO(lrn): Better handling of allocation errors. Try harder I'm not sure this should be a TODO. It may be better to always follow the policy of failing on GC, and work on making this case rare, rather than inlining it in many special places. http://codereview.chromium.org/5443001/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
