Thanks for the patch. There are a few cosmetic issues, see below.
http://codereview.chromium.org/5471001/diff/1/src/platform-win32.cc
File src/platform-win32.cc (right):
http://codereview.chromium.org/5471001/diff/1/src/platform-win32.cc#newcode209
src/platform-win32.cc:209:
Extra blank line needed here (2 blank lines between functions).
http://codereview.chromium.org/5471001/diff/1/src/platform-win32.cc#newcode866
src/platform-win32.cc:866: intptr_t address = (intptr_t)NULL;
We don't allow C-style casts in V8. See the Google C++ Style Guide. I
think just putting 0 in here would be OK.
http://codereview.chromium.org/5471001/diff/1/src/platform-win32.cc#newcode872
src/platform-win32.cc:872: if (prot == PAGE_EXECUTE_READWRITE && msize
= (size_t)Page::kPageSize) {
C-style cast
http://codereview.chromium.org/5471001/diff/1/src/platform-win32.cc#newcode882
src/platform-win32.cc:882: if (mbase == NULL && address !=
(intptr_t)NULL)
C-style cast
http://codereview.chromium.org/5471001/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
