http://codereview.chromium.org/5524006/diff/1/src/jsregexp.h File src/jsregexp.h (right):
http://codereview.chromium.org/5524006/diff/1/src/jsregexp.h#newcode600 src/jsregexp.h:600: virtual int EatsAtLeast(int still_to_find, On 2010/12/03 09:12:43, Lasse Reichstein wrote:
Add explanation of not_at_start parameter - what happens if it's true
vs. false.
Consider renaming to a positive name (at_start), or better something
that
captures the positive of "may be at start" vs. "definitly not at
start". I think I will explain, but not rename, since we use this polarity in many places. http://codereview.chromium.org/5524006/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
