Reviewers: Mads Ager, fschneider,
Message:
Quick summary: there are two new virtual member functions,
AstContext::ReturnValue and AstContext::ReturnInstruction. The first is
used for
"pure" values that have already been emitted in the instruction stream (or
don't
need to be) and had any side effects addressed, the second for instructions
that
need to be emitted into the instruction stream and possibly have their
environment recorded.
They are called in tail position when visiting an instruction and passed the
value of the instruction.
Though I've mostly just moved code around (I was trying to preserve the
existing
graph construction wherever possible), there are already some advantages. I
have plans for more simplification and streamlining of the graph
construction
process.
Description:
Change the HGraphBuilder to dispatch on the context.
Before, expressions didn't take advantage of knowing their context in
the AST. Now, we use the context to decide what to do with a value at
the end of visiting an expression.
Please review this at http://codereview.chromium.org/5620007/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/hydrogen.h
M src/hydrogen.cc
M test/sputnik/README
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
