LGTM. This looks much better!
http://codereview.chromium.org/5620007/diff/1/src/hydrogen.cc File src/hydrogen.cc (right): http://codereview.chromium.org/5620007/diff/1/src/hydrogen.cc#newcode3720 src/hydrogen.cc:3720: instr->set_position(expr->position()); It seems easy to forget setting the source position. Can the ReturnInstruction take it as an argument? Or maybe can you easily assert inside ReturnInstruction that all HInstructions that have require a position have it set? http://codereview.chromium.org/5620007/diff/1/src/hydrogen.cc#newcode4303 src/hydrogen.cc:4303: if (ast_context()->IsEffect()) AddSimulate(expr->id()); Shouldn't this be if (ast_context()->IsTest()) ... then? http://codereview.chromium.org/5620007/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
