Reviewers: Søren Gjesse,
Description:
Change test script to make it easy to run crankshaft tests on ARM and
x64 where crankshaft is not the default. Add ability to add custom
expectations for running in this special crankshaft mode.
The expectations are not updated in this change. There are a couple of
bugs that I would like to fix before doing that. Otherwise the lists
will be very long. :)
Please review this at http://codereview.chromium.org/5787001/
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M test/mjsunit/mjsunit.status
M tools/test.py
Index: test/mjsunit/mjsunit.status
===================================================================
--- test/mjsunit/mjsunit.status (revision 5956)
+++ test/mjsunit/mjsunit.status (working copy)
@@ -104,7 +104,12 @@
regress/regress-3218915: SKIP
regress/regress-3247124: SKIP
+##############################################################################
+[ $arch == arm && $crankshaft ]
+# Test that currently fail with crankshaft on ARM.
+compiler/simple-osr: FAIL
+
##############################################################################
[ $arch == mips ]
Index: tools/test.py
===================================================================
--- tools/test.py (revision 5956)
+++ tools/test.py (working copy)
@@ -729,7 +729,10 @@
if self.name in env: return ListSet([env[self.name]])
else: return Nothing()
+ def Evaluate(self, env, defs):
+ return env[self.name]
+
class Outcome(Expression):
def __init__(self, name):
@@ -1175,6 +1178,9 @@
result.add_option("--nostress",
help="Don't run crankshaft --always-opt --stress-op
test",
default=False, action="store_true")
+ result.add_option("--crankshaft",
+ help="Run with the --crankshaft flag",
+ default=False, action="store_true")
return result
@@ -1209,6 +1215,11 @@
VARIANT_FLAGS = [['--stress-opt', '--always-opt']]
if options.nostress:
VARIANT_FLAGS = [[],['--nocrankshaft']]
+ if options.crankshaft:
+ if options.special_command:
+ options.special_command += " --crankshaft"
+ else:
+ options.special_command = "@--crankshaft"
return True
@@ -1359,7 +1370,8 @@
'mode': mode,
'system': utils.GuessOS(),
'arch': options.arch,
- 'simulator': options.simulator
+ 'simulator': options.simulator,
+ 'crankshaft': options.crankshaft
}
test_list = root.ListTests([], path, context, mode)
unclassified_tests += test_list
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
