LGTM. On Fri, Dec 10, 2010 at 2:07 PM, <[email protected]> wrote:
> Reviewers: Kevin Millikin, > > Description: > Ensure that default value is explicitly initialized in DefineOwnProperty. > > TBR: kmillikin > > Please review this at http://codereview.chromium.org/5781002/ > > Affected files: > M src/v8natives.js > > > Index: src/v8natives.js > diff --git a/src/v8natives.js b/src/v8natives.js > index > 894df1402598cadb5b93ac06da0075feb9d45d4f..8e057037e4cf08c9ef5f46ef9a225b44d9064b88 > 100644 > --- a/src/v8natives.js > +++ b/src/v8natives.js > @@ -615,7 +615,7 @@ function DefineOwnProperty(obj, p, desc, should_throw) > { > } else { > flag |= READ_ONLY; > } > - var value; // Default value is undefined. > + var value = void 0; // Default value is undefined. > if (desc.hasValue()) { > value = desc.getValue(); > } else if (!IS_UNDEFINED(current)) { > > > -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
