On 2010/12/10 14:12:56, Karl Klose wrote:
> It seems wrong that state window tracking is done in
SuspendIfNecessary. Why
not
> move this to NotifyTick instead? Added bonus: this way it'll only be
used
when
> the runtime profiler is enabled.
We also want to sample the state when the runtime profiler is suspended,
but
NotifyTick is not called in this case.
SuspendIfNecessary is called on every tick and returns true if the runtime
profiler should not be called. The calling code is in
Sampler::PlatformData::SignalSender()
http://codereview.chromium.org/5720003/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev