http://codereview.chromium.org/5716001/diff/1/tools/gyp/v8.gyp File tools/gyp/v8.gyp (right):
http://codereview.chromium.org/5716001/diff/1/tools/gyp/v8.gyp#newcode33 tools/gyp/v8.gyp:33: 'host_arch%': '<(target_arch)', Removed. http://codereview.chromium.org/5716001/diff/1/tools/gyp/v8.gyp#newcode200 tools/gyp/v8.gyp:200: 'target_name': 'v8-preparser', On 2010/12/09 14:08:00, Søren Gjesse wrote:
- -> _, other targets use underscore.
Done. http://codereview.chromium.org/5716001/diff/1/tools/gyp/v8.gyp#newcode227 tools/gyp/v8.gyp:227: ['OS=="linux" and library=="shared_library"', { On 2010/12/09 14:08:00, Søren Gjesse wrote:
I also think -fPIC should be provided by the consumer of v8.gyp. We
don't set
-fPIC for any other targets in this file.
Done. http://codereview.chromium.org/5716001/diff/1/tools/gyp/v8.gyp#newcode230 tools/gyp/v8.gyp:230: ['v8_target_arch!="x64" and host_arch=="x64"', { Removed. http://codereview.chromium.org/5716001/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
