LGTM.
http://codereview.chromium.org/5798002/diff/1/src/ia32/codegen-ia32.cc File src/ia32/codegen-ia32.cc (right): http://codereview.chromium.org/5798002/diff/1/src/ia32/codegen-ia32.cc#newcode9637 src/ia32/codegen-ia32.cc:9637: int delta_to_record_write = 0x0001; Why is this suddenly an unnamed constant? http://codereview.chromium.org/5798002/diff/1/src/mark-compact.cc File src/mark-compact.cc (right): http://codereview.chromium.org/5798002/diff/1/src/mark-compact.cc#newcode2358 src/mark-compact.cc:2358: if (!FLAG_new_gc && Heap::map_space()->NeedsCompaction(live_maps)) { Shouldnt this be !FLAG_never_compact. Looks a little like a bug in the old GC. http://codereview.chromium.org/5798002/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
