http://codereview.chromium.org/5753005/diff/1/src/compiler.cc File src/compiler.cc (right):
http://codereview.chromium.org/5753005/diff/1/src/compiler.cc#newcode168 src/compiler.cc:168: if (!info->AllowOptimize()) info->DisableOptimization(); BTW, if I understand meaning of Scope::num_heap_slots correctly, I was probably too quick to remove it---it allowed us to bail out earlier (not in ScopeSetup). What do you think? On 2010/12/13 22:41:04, antonm wrote:
On 2010/12/13 19:00:18, fschneider wrote: > This checks if the function literal's scope has any heap allocated
slots. So I
> think this check can go away with your change.
I am not sure: CompilationInfo::AllowOptimize checks if crankshaft is
enabled
and if closure_ is not null. I removed Scope::AllowOptimize as per
your
suggestion on IM---thanks a lot for spotting this.
http://codereview.chromium.org/5753005/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
