Hi Soren
Wanted to ask your advice. I added new evaluate parameter
'additional_context' to wiki
http://code.google.com/p/v8/wiki/DebuggerProtocol
"additional_context" : { <name1> : <handle1>, <name2> : <handle2> ... }
and noticed that my protocol change is arguable: I use runtime values
(variable names) as *keys* in protocol. This means you cannot build a schema
for such protocol anymore.
Do you think it's worth redoing it in a more regular way? E.g. like this:
"additional_context" : [ { "name" : <name1>, "handle" : <handle1> } , {
"name" : <name2>, "handle" : <handle2> }, ... ]
Here all runtimes values are packed as *values* and all protocol *keys* are
static.
Peter
2010/12/10 <[email protected]>
> Reviewers: Søren Gjesse,
>
> Message:
> Hi Soren
>
> I'd like to extend evaluate semantics in remote debug protocol. This fix
> allows
> remote client to use handles in evaluate commands.
>
> I'm planning to implement such features as "calculate toString", "pin-point
> this
> reference to a global object" etc on top of this feature.
>
> Peter
>
> Description:
> Introduce additional context to evaluate operations
>
> Please review this at http://codereview.chromium.org/5733001/
>
> SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
>
> Affected files:
> M src/debug-debugger.js
> M src/mirror-debugger.js
> M src/runtime.h
> M src/runtime.cc
> A test/mjsunit/debug-evaluate-with-context.js
>
>
>
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
