I really like the approach!

How about hiding a bit more of the implementation details? We now rely pretty
heavily on the previous instruction being test, so maybe we should wrap this
stuff into a single function, e.g.:
JumpPatchSite patch_site(masm);
patch_site.JumpIfSmi(&call_stub);
or
patch_site.JumpIfNotSmi(&call_stub);
I think it'll also be easier to read.

-- Vitaly


http://codereview.chromium.org/5763004/

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to