LGTM
Should be easy to find all the places where we have write barrier code
now. I'm
surprised at how many places that is.
http://codereview.chromium.org/5736008/diff/1/src/arm/full-codegen-arm.cc
File src/arm/full-codegen-arm.cc (right):
http://codereview.chromium.org/5736008/diff/1/src/arm/full-codegen-arm.cc#newcode640
src/arm/full-codegen-arm.cc:640: int offset =
Context::SlotOffset(slot->index());
Seems like this ifdef and about 10 others could have been avoided if we
had just put the ifdef in RecordWrite. Also there's nothing CARDMARKING
about this code. Any other write barrier that uses the same number of
registers could be called here.
http://codereview.chromium.org/5736008/diff/1/src/globals.h
File src/globals.h (right):
http://codereview.chromium.org/5736008/diff/1/src/globals.h#newcode30
src/globals.h:30:
Inadvertent edit
http://codereview.chromium.org/5736008/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
